From: mixxlto <maxtan0626@gmail.com>
Date: Thu, 15 Jan 2026 05:29:30 +0000 (-0800)
Subject: more stinky variable names
X-Git-Url: https://git.taranathan.com/?a=commitdiff_plain;h=4f7d55a93af4044cd76cfa425cc5e2102e6307a2;p=FRC2026.git

more stinky variable names
---

diff --git a/src/main/java/frc/robot/util/ShooterPhysics.java b/src/main/java/frc/robot/util/ShooterPhysics.java
index 39170de..e342f41 100644
--- a/src/main/java/frc/robot/util/ShooterPhysics.java
+++ b/src/main/java/frc/robot/util/ShooterPhysics.java
@@ -2,6 +2,8 @@ package frc.robot.util;
 
 import java.util.Optional;
 
+import com.google.errorprone.annotations.CheckReturnValue;
+
 import edu.wpi.first.math.geometry.Rotation2d;
 import edu.wpi.first.math.geometry.Translation2d;
 import edu.wpi.first.math.geometry.Translation3d;
diff --git a/src/test/java/frc/robot/util/ShooterPhysicsTest.java b/src/test/java/frc/robot/util/ShooterPhysicsTest.java
index 1b524a5..ed0bee1 100644
--- a/src/test/java/frc/robot/util/ShooterPhysicsTest.java
+++ b/src/test/java/frc/robot/util/ShooterPhysicsTest.java
@@ -124,13 +124,13 @@ class ShooterPhysicsTest {
 	@Test
 	public void velocityTest() {
 		// just make sure it converges properly
-		Optional<Translation3d> translation = ShooterPhysics.getImpulseForSpeed(new Translation2d(4.2, -3),
+		Optional<Translation3d> translation = ShooterPhysics.getExitVelocityForSpeed(new Translation2d(4.2, -3),
 				new Translation3d(1, 2, 3), 20);
 		assertTrue(translation.isPresent());
 		assertEquals(translation.get().getNorm(), 20, 0.1);
 
 		// check something impossible is impossible
-		Optional<Translation3d> translation2 = ShooterPhysics.getImpulseForSpeed(Translation2d.kZero,
+		Optional<Translation3d> translation2 = ShooterPhysics.getExitVelocityForSpeed(Translation2d.kZero,
 				new Translation3d(100, 0, 5), 10);
 		assertTrue(translation2.isEmpty());
 	}