From 4f7d55a93af4044cd76cfa425cc5e2102e6307a2 Mon Sep 17 00:00:00 2001 From: mixxlto Date: Wed, 14 Jan 2026 21:29:30 -0800 Subject: [PATCH] more stinky variable names --- src/main/java/frc/robot/util/ShooterPhysics.java | 2 ++ src/test/java/frc/robot/util/ShooterPhysicsTest.java | 4 ++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/main/java/frc/robot/util/ShooterPhysics.java b/src/main/java/frc/robot/util/ShooterPhysics.java index 39170de..e342f41 100644 --- a/src/main/java/frc/robot/util/ShooterPhysics.java +++ b/src/main/java/frc/robot/util/ShooterPhysics.java @@ -2,6 +2,8 @@ package frc.robot.util; import java.util.Optional; +import com.google.errorprone.annotations.CheckReturnValue; + import edu.wpi.first.math.geometry.Rotation2d; import edu.wpi.first.math.geometry.Translation2d; import edu.wpi.first.math.geometry.Translation3d; diff --git a/src/test/java/frc/robot/util/ShooterPhysicsTest.java b/src/test/java/frc/robot/util/ShooterPhysicsTest.java index 1b524a5..ed0bee1 100644 --- a/src/test/java/frc/robot/util/ShooterPhysicsTest.java +++ b/src/test/java/frc/robot/util/ShooterPhysicsTest.java @@ -124,13 +124,13 @@ class ShooterPhysicsTest { @Test public void velocityTest() { // just make sure it converges properly - Optional translation = ShooterPhysics.getImpulseForSpeed(new Translation2d(4.2, -3), + Optional translation = ShooterPhysics.getExitVelocityForSpeed(new Translation2d(4.2, -3), new Translation3d(1, 2, 3), 20); assertTrue(translation.isPresent()); assertEquals(translation.get().getNorm(), 20, 0.1); // check something impossible is impossible - Optional translation2 = ShooterPhysics.getImpulseForSpeed(Translation2d.kZero, + Optional translation2 = ShooterPhysics.getExitVelocityForSpeed(Translation2d.kZero, new Translation3d(100, 0, 5), 10); assertTrue(translation2.isEmpty()); } -- 2.39.5